Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecating protected topics in favor of protected shards #2983

Merged
merged 10 commits into from
Aug 19, 2024
Merged

chore: deprecating protected topics in favor of protected shards #2983

merged 10 commits into from
Aug 19, 2024

Conversation

gabrielmer
Copy link
Contributor

@gabrielmer gabrielmer commented Aug 16, 2024 •
edited
Loading

Description

Deprecating --protected-topic in favor of --protected-shard and modifying it to only support static sharding.

We currently support both configurations and their respective formats, and after two releases we can completely remove the --protected-topic config

Changes

  • adding protected-shard configuration
  • implementing logic for protected shards
  • converting protected topics to protected shards so both are supported while we announce the deprecation of the former
  • updated tests

Issue

Advances #2806

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2983

Built from 522ff12

@gabrielmer gabrielmer marked this pull request as ready for review August 16, 2024 13:33
jm-clius
jm-clius approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ivansete-status
Ivansete-status approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯
Just added minor nitpick comments :)

waku/factory/external_config.nim Show resolved Hide resolved
waku/factory/external_config.nim Outdated Show resolved Hide resolved
waku/factory/external_config.nim Outdated Show resolved Hide resolved
waku/factory/validator_signed.nim Outdated Show resolved Hide resolved
@gabrielmer gabrielmer force-pushed the chore-deprecating-protected-topics-for-protected-shards branch from fe5470d to b9a3b5e Compare August 19, 2024 09:41
@gabrielmer gabrielmer added the release-notes Issue/PR needs to be evaluated for inclusion in release notes highlights or upgrade instructions label Aug 19, 2024
@gabrielmer gabrielmer mentioned this pull request Aug 19, 2024
Closed
@gabrielmer gabrielmer merged commit e51ffe0 into master Aug 19, 2024
9 of 11 checks passed
@gabrielmer gabrielmer deleted the chore-deprecating-protected-topics-for-protected-shards branch August 19, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@jm-clius jm-clius jm-clius approved these changes

@SionoiS SionoiS Awaiting requested review from SionoiS

@darshankabariya darshankabariya Awaiting requested review from darshankabariya

@NagyZoltanPeter NagyZoltanPeter Awaiting requested review from NagyZoltanPeter

Assignees

@gabrielmer gabrielmer

Labels
E:nwaku Sharding peer management and discovery release-notes Issue/PR needs to be evaluated for inclusion in release notes highlights or upgrade instructions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielmer @jm-clius @Ivansete-status